Add more BSplineSpace constructor (#336)

* add more `BSplineSpace` constructor * add test for new `BSplineSpace` constructor
hyrodium · Oct 16, 2023 · 8f9f77a · 8f9f77a
1 parent 2747acb
commit 8f9f77a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/_BSplineSpace.jl b/src/_BSplineSpace.jl
@@ -54,6 +54,9 @@ end
 function BSplineSpace{p,T,K}(P::BSplineSpace{p}) where {p,T,K}
     return BSplineSpace{p,T}(K(knotvector(P)))
 end
+function BSplineSpace{p,T,K}(k::AbstractKnotVector) where {p,T,K}
+    return BSplineSpace{p,T}(K(k))
+end
 
 # Broadcast like a scalar
 Base.Broadcast.broadcastable(P::BSplineSpace) = Ref(P)

diff --git a/test/test_BSplineSpace.jl b/test/test_BSplineSpace.jl
@@ -6,9 +6,10 @@
         P4 = BSplineSpace{2,Real}(P1)
         P5 = BSplineSpace{2,Float64}(P1)
         P6 = BSplineSpace{2,Float64}(KnotVector(1:8))
+        P7 = BSplineSpace{2,Float64,KnotVector{Float64}}(KnotVector(1:8))
         @test P1 == P2 == P3 == P4 == P5 == bsplinespace(P1) == bsplinespace(P2) == bsplinespace(P3) == bsplinespace(P4) == bsplinespace(P5)
-        @test P5 == P6
-        @test typeof(P5) === typeof(P6)
+        @test P5 == P6 == P7
+        @test typeof(P5) === typeof(P6) === typeof(P7)
         @test P1 isa BSplineSpace{2,Int}
         @test P2 isa BSplineSpace{2,Int}
         @test P3 isa BSplineSpace{2,Int}