Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged HT07_Summer_Testing Branch w/ Test_Coulomb_Counting Branch #12

Merged
merged 14 commits into from
Apr 5, 2024
Merged

Merged HT07_Summer_Testing Branch w/ Test_Coulomb_Counting Branch #12

merged 14 commits into from
Apr 5, 2024

Conversation

FemK157
Copy link

@FemK157 FemK157 commented Apr 5, 2024

Pull Request (PR) into Code-2024

Code Description

Merged AMS code from the two branches in the title.

Testing Description

Tested current shunt code on Test_coulomb_counting branch on the ACU Teensy and saw that it showed on CAN. About to test energy meter/current shunt data on HT08.

Checklist

  • Is this code linked to a new board or board rev?
    • Is there a PR for that board in circuits-2024? If so, please pause until that PR is merged.
  • If you made a change or addition or deletion to the CAN library, did you inform the Data Aq lead?
  • Did you test the code in real-world conditions before submitting?
    • Did you use CPU Speed = 720 MHz (overclock) and Optimize = Fastest when testing with Teensy 4.x?
    • Did you use CPU Speed = 144 MHz (overclock) and Optimize = Fastest with LTO when testing with Teensy 3.5?
    • Did you use CPU Speed = 120 MHz (overclock) and Optimize = Fastest with LTO when testing with Teensy 3.2?
    • Did you use Teensyduino 1.56 with Arduino 1.8.19 when testing with the latest libraries from main?
  • Did you pull main into your branch?
    • Did you check for merge conflicts?
    • Did you resolve any that occurred? If you are having trouble or are confused, contact a lead!
  • Did you fill out the above template?
  • Did you assign the right people for review (on the right)?

@FemK157 FemK157 requested a review from CL16gtgh April 5, 2024 01:25
@FemK157 FemK157 merged commit ad93714 into ht07summerTesting Apr 5, 2024
@FemK157 FemK157 deleted the Test_coulomb_counting branch April 5, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CL16gtgh CL16gtgh CL16gtgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FemK157 @CL16gtgh @BANANAPEEL202 @EricGalluzzi