Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#21 Add link to first/last page to navigation #23

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

Bartlomiejsz
Copy link
Contributor

Hi @Vinai,
this is awesome replacement for native grids, let's see if I can help here a bit :)

@Bartlomiejsz Bartlomiejsz force-pushed the feature/first-last-page branch from ccde0da to 5e47bdf Compare January 14, 2021 09:42
@Vinai
Copy link
Collaborator

Vinai commented Jan 14, 2021

Thank you very much, awesome 👍
The unit tests fail because the MAGENTO_MARKETPLACE_USERNAME and MAGENTO_MARKETPLACE_PASSWORD are not set as a repo secret.

I've checked out the branch locally, it looks good and all tests pass.

@Vinai Vinai merged commit e71f1df into hyva-themes:main Jan 14, 2021
@Bartlomiejsz
Copy link
Contributor Author

That's weird @Vinai, once those failed first time I did set up both secrets on my fork:
image
and it still failed

However, thanks for quick action :)

@Vinai
Copy link
Collaborator

Vinai commented Jan 14, 2021

Strange indeed. I'm using actions based on https://github.com/extdn/github-actions-m2.
The integration build works without the credentials, it's only the unit tests that require them.
I want to update the action so it doesn't require those settings either... it's annoying if they don't work for PRs-

@Bartlomiejsz Bartlomiejsz deleted the feature/first-last-page branch January 14, 2021 10:20
@Vinai
Copy link
Collaborator

Vinai commented Jan 14, 2021

I've added a custom docker entrypoint that uses the repo-magento-mirror.fooman.co.nz mirror repo and removed the need for the secrets. Thanks @fooman a.k.a. Christof you are such a treasure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants