feat: kakao-tech-campus-2nd-step3#8 guardians 코드리뷰 반영

hyyyh0x · Sep 22, 2024 · 7a5daa5 · 7a5daa5
1 parent 3c623f0
commit 7a5daa5
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 14 deletions.
diff --git a/...in/guardians/AuthGuardiansController.java → ...n/guardians/AdminGuardiansController.java b/...in/guardians/AuthGuardiansController.java → ...n/guardians/AdminGuardiansController.java
@@ -2,6 +2,7 @@
 
 import jakarta.validation.Valid;
 import java.util.List;
+import lombok.RequiredArgsConstructor;
 import org.hibernate.annotations.Comment;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
@@ -13,16 +14,13 @@
 import org.springframework.web.bind.annotation.RestController;
 
 @RestController
-@RequestMapping("/v1/auth/guardians")
+@RequestMapping("/v1/admin/guardians")
+@RequiredArgsConstructor
 @Comment("관리자 페이지의 보호자 관리")
-public class AuthGuardiansController {
+public class AdminGuardiansController {
 
     private final GuardiansService guardiansService;
 
-    public AuthGuardiansController(GuardiansService guardiansService) {
-        this.guardiansService = guardiansService;
-    }
-
     @Comment("보호자 전부 조회")
     @GetMapping
     public ResponseEntity<List<GuardiansResponse>> showAllGuardians() {

diff --git a/src/main/java/dbdr/domain/guardians/Guardians.java b/src/main/java/dbdr/domain/guardians/Guardians.java
@@ -4,12 +4,16 @@
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
 import jakarta.persistence.Table;
+import lombok.AccessLevel;
+import lombok.Builder;
 import lombok.Getter;
+import lombok.NoArgsConstructor;
 import org.hibernate.annotations.Comment;
 
 @Entity
 @Getter
 @Table(name = "guardians")
+@NoArgsConstructor(access = AccessLevel.PROTECTED)
 public class Guardians extends BaseEntity {
 
     @Comment("보호자 전화번호")
@@ -19,14 +23,13 @@ public class Guardians extends BaseEntity {
     @Column(nullable = false)
     private String name;
 
-    public Guardians() {
-    }
-
+    @Builder
     public Guardians(String phone, String name) {
         this.phone = phone;
         this.name = name;
     }
 
+    @Builder
     public void updateGuardian(String phone, String name) {
         this.phone = phone;
         this.name = name;

diff --git a/src/main/java/dbdr/domain/guardians/GuardiansController.java b/src/main/java/dbdr/domain/guardians/GuardiansController.java
@@ -1,6 +1,7 @@
 package dbdr.domain.guardians;
 
 import jakarta.validation.Valid;
+import lombok.RequiredArgsConstructor;
 import org.hibernate.annotations.Comment;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
@@ -12,15 +13,12 @@
 
 @RestController
 @RequestMapping("/v1/guardians")
+@RequiredArgsConstructor
 @Comment("보호자 관련 API")
 public class GuardiansController {
 
     private final GuardiansService guardiansService;
 
-    public GuardiansController(GuardiansService guardiansService) {
-        this.guardiansService = guardiansService;
-    }
-
     @Comment("보호자 자신 정보 조회")
     @GetMapping("/{guardianId}")
     public ResponseEntity<GuardiansResponse> showGuardianInfo(

diff --git a/src/main/java/dbdr/domain/guardians/GuardiansRequest.java b/src/main/java/dbdr/domain/guardians/GuardiansRequest.java
@@ -1,10 +1,12 @@
 package dbdr.domain.guardians;
 
 import jakarta.validation.constraints.NotBlank;
+import jakarta.validation.constraints.Pattern;
 import org.hibernate.annotations.Comment;
 
 public record GuardiansRequest(
-    @Comment("보호자 전화번호") @NotBlank(message = "전화번호를 입력하세요.") String phone,
+    @Comment("보호자 전화번호") @NotBlank(message = "전화번호를 입력하세요.")
+    @Pattern(regexp = "010\\d{8}", message = "010XXXXXXXX형식으로 입력해주세요.") String phone,
     @Comment("보호자 성명") @NotBlank(message = "이름을 입력하세요.") String name) {
 
 }