-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-loadermixin needs to be a regular dependency, not devDependency #13
Comments
Hmm, well |
For |
Interesting. AFAIK npm should auto-install peer dependencies if they are missing (at least, until 3.x is released). Is it possible you're running an edge version of npm? |
hm, deleted node_modules, pruned package.json, reran it, and you're right: it installed just fine. I guess that means this can be closed, sorry to bother and thanks for the reponse! |
👍 thanks for providing the sanity check! We may still have to do something when the next version of npm is released, since peer dependencies will stop auto-installing then… |
react
,react-loadermixin
andxtend
are required by the imageloader code, and should be normal dependencies, rather than devDependencies.The text was updated successfully, but these errors were encountered: