This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Discover View #1622
Merged
Discover View #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thisandagain
commented
May 1, 2015
thisandagain
commented
| <img src="../../img/toucan.svg" /> | ||
| </div> | ||
| var cards = []; | ||
| var project = null; |
There was a problem hiding this comment.
var project; no need for null here?
| @@ -64,6 +60,8 @@ | |||
| "lodash.defaults": "3.1.1", | |||
| "react": "0.13.1", | |||
| "react-hammerjs": "0.2.2", | |||
| "react-imageloader": "1.2.0", | |||
| "react-loadermixin": "1.0.4", | |||
There was a problem hiding this comment.
ImageLoader is used in discover.jsx. LoaderMixin is a dependency of the image loader.
There was a problem hiding this comment.
Looks like a dep. bug in image-loader. Filed hzdg/react-imageloader#13
| </ImageLoader> | ||
| </div> | ||
|
|
||
| <div className="meta"> |
There was a problem hiding this comment.
might be worth turning this into a <Metadata> component. Right now we're using title and author only, but we probably want to extend that later on with additional things like date posted, likes, etc.
|
|
||
| #### Loading Images | ||
| Any time you are loading images over the network, we recommend that you use the `ImageLoader` react component. This gives you access to important events like loading and error states as well as a hook for providing a loading animation. Full documentation can be found here: https://github.com/hzdg/react-imageloader |
There was a problem hiding this comment.
small nit: let's use <ImageLoader> to make it clear that it's not a library or the like, but an actual component
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.