Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve vitest logging #8

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

Tomas2D
Copy link
Contributor

@Tomas2D Tomas2D commented Sep 20, 2024

Which issue(s) does this pull-request address?

Ref: #7

Description

This PR alters Vitest logging in a way such that when there is FrameworkError, we print the whole error so one can see what really happened. Prior to this PR, one could only see the error message.

Checklist

  • I have read the contributor guide
  • Linting passes: yarn lint or yarn lint:fix
  • Formatting is applied: yarn format or yarn format:fix
  • Unit tests pass: yarn test:unit
  • E2E tests pass: yarn test:e2e
  • Tests are included
  • Documentation is changed or added
  • Commit messages and PR title follow conventional commits

Copy link
Collaborator

@grahamwhiteuk grahamwhiteuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have the desired effect of giving a lot more error context for tests runs e.g. https://github.com/i-am-bee/bee-community-tools/actions/runs/10956024754/job/30421152475

@grahamwhiteuk grahamwhiteuk merged commit c5e4a3d into main Sep 20, 2024
1 check failed
@grahamwhiteuk grahamwhiteuk deleted the feat/7-vitest-logging branch September 20, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants