Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaultValue tests and allow second arg string as defaultValue #1206

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Add defaultValue tests and allow second arg string as defaultValue #1206

merged 1 commit into from
Feb 13, 2019

Conversation

rosskevin
Copy link
Collaborator

Closes #1198

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.275% when pulling 0f00f59 on rosskevin:ts-t-defaultvalue-string into 4e4c75b on i18next:master.

@rosskevin rosskevin merged commit 69f7402 into i18next:master Feb 13, 2019
@rosskevin
Copy link
Collaborator Author

This can be a patch release @jamuhl

@rosskevin rosskevin deleted the ts-t-defaultvalue-string branch February 13, 2019 23:14
@jamuhl
Copy link
Member

jamuhl commented Feb 14, 2019

published in i18next@15.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosskevin @coveralls @jamuhl