Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ComponentType for Trans' parent type. #1021

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Allow ComponentType for Trans' parent type. #1021

merged 1 commit into from
Dec 13, 2019

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Dec 13, 2019

I've also allowed null as this is the cleanest way I use to override the default parent:

  • undefined -> use default parent from settings
  • string | React.ComponentType<any> -> use in React.createElement
  • null -> do not add a parent

@coveralls
Copy link

coveralls commented Dec 13, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 95.261% when pulling f705959 on pcorpet:parent-type into 40b77e0 on i18next:master.

rosskevin
rosskevin suggested changes Dec 13, 2019
View reviewed changes
Copy link
Collaborator

@rosskevin rosskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the usage tests in test/typescript and add these additional cases to prevent regressions.

@pcorpet
Copy link
Contributor Author

pcorpet commented Dec 13, 2019

Please update the usage tests in test/typescript and add these additional cases to prevent regressions.

Done. Thanks for the quick review.

rosskevin
rosskevin approved these changes Dec 13, 2019
View reviewed changes
Copy link
Collaborator

@rosskevin rosskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates

@rosskevin rosskevin merged commit 092bd44 into i18next:master Dec 13, 2019
@rosskevin
Copy link
Collaborator

This can be a patch release

@jamuhl
Copy link
Member

jamuhl commented Dec 18, 2019

sorry for the delay...was published in react-i18next@11.2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosskevin rosskevin rosskevin approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcorpet @coveralls @rosskevin @jamuhl