-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update t
function types to rely on types coming from i18next
#1501
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bump, not stale! @pedrodurek what is blocking on this PR? Is there something I can do to help push it along? For context the issue we are facing is the following, and going on the title of this PR it should fix the issue we are seeing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is good to go. I'll leave a request change
to bump the minimum i18next once i18next/i18next#1775 is released.
Thank you @pedrodurek
v22.0.0 is now published |
@pedrodurek let me know when this can be merged |
Hey @adrai, this is good now. It needs to be a |
Later today (my timezone 😛), I'll update the |
@rosskevin as soon as you approve, I'll create a new major version... btw: in case you're interested: i18next/next-i18next#1966 |
Thank you for your contributions... |
Incredible; thank you all so much for such a quick turnaround! 😍 |
Dependent on i18next/i18next#1775
We'll no longer support typescript below v4.1
Checklist
npm run test
Checklist (for documentation change)