ICU: Trans macro will parse defaults as alternate to children #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for i18next/i18next#1295 Adds support for ICU message syntax inside the `defaults` attribute This allows the Trans macro to be used with linters and other code analysis tools that expect valid JSX syntax as children, by using the defaults prop instead of children for the message. Also adds support fo the `<SelectOrdinal>` tag Fixes a bug where `Trans` was imported from 'react/i18next' instead of 'react-i18next'
|
I'm not sure if I am supposed to commit react-i18n.js and react-i18next.min.js or not. |
|
Would you like me to split up the icu.macro.js file to get the line count under 250 to fix the codeclimate issue? |
redbugz
added a commit
to redbugz/react-i18next-gitbook
that referenced
this pull request
Aug 9, 2019
|
@redbugz no you can ignore the code climate for this one - I'm ok with that I will merge this later today and publish an updated version...thank you for contributing |
|
published in react-i18next@10.12.0 |
|
If you like this module don’t forget to star this repo. Make a tweet, share the word or have a look at our https://locize.com to support the devs of this project -> there are many ways to help this project 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for i18next/i18next#1295
Adds support for ICU message syntax inside the
defaultsattributeThis allows the Trans macro to be used with linters and other code analysis
tools that expect valid JSX syntax as children, by using the defaults
prop instead of children for the message.
Also adds support fo the
<SelectOrdinal>tagFixes a bug where
Transwas imported from 'react/i18next' instead of 'react-i18next'