pulseaudio: Retry until ready (w/ timeout) #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor issue but immediately after pulse_initialize() is called for the first time, the condition `if (!context_ready || default_sink_idx == DEFAULT_SINK_INDEX)` in description_pulseaudio() fails. If a pulse device is explicitly specified, the first volume that i3status prints gets assigned to zero. Otherwise, with the default device, the ALSA fallback is used, unnecessarily initializing other resources. This patch implements a small wait that is run only once during i3status' lifetime. Fixes a small memleak that for some reason happens with the ALSA fall-back if pulseaudio is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.