-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port memory printing on OpenBSD #493
base: main
Are you sure you want to change the base?
Conversation
lucic71
commented
Jul 21, 2022
- Split print_memory into get_memory_info which is platform dependent and print_formatted_memory which is platform independent
- Created struct print_mem_info that keeps memory counters which will be passed between get_memory_info and print_formatted_memory
- Used UVM subsystem to get memory counters on OpenBSD
- Added the requirements in README
- src/print_cpu_usage.c does not compile on OpenBSD because of the conditional definition of __OpenBSD__
This function will be called from all architectures
I still need to find a way to get buffers, cached and shared memory. If you have any idea how to do that it would be much appreciated. |
@stapelberg is this repo still active? |
Yes, this is still active, but I don’t really have time to answer development questions, sorry. I can try to review and merge your PR once you let me know it’s ready (it sounded like it wasn’t ready currently). |
…1/i3status into feature/print_mem_openbsd
@stapelberg, it's ready for reviewing! |
Thanks, this looks reasonable on first glance. Can you format your code with clang-format to make the CI pass? Have you run the tests yet to ensure they pass, too? |