Fix handling of POWER_SUPPLY_TIME_TO_* properties #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The POWER_SUPPLY_TIME_TO_* properties provided via sysfs have to be interpreted as seconds. Further, the presence of both the POWER_SUPPLY_TIME_TO_EMPTY_NOW and POWER_SUPPLY_TIME_TO_FULL_NOW properties confused the logic and ended up always showing the time-to-full as 0 while charging (since TIME_TO_EMPTY reports 0 with a charger attached).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the linux kernel documentation, the POWER_SUPPLY_TIME_TO_* properties provided via sysfs have to be interpreted as seconds, not minutes:
https://github.com/torvalds/linux/blob/master/include/linux/power_supply.h#L22
The driver that was originally used for developing support in i3status (#378) is broken, since it incorrectly returns the time-to-empty in minutes instead of seconds.
Further, POWER_SUPPLY_TIME_TO_EMPTY_NOW is present even when charging, but reports a value if "0" then. This confuses the logic and ended up always showing the time-to-full as 0. The proposed patch fixes the unit interpretation, as well as added code to parse both time-to-empty and time-to-full, disregarding zero-values.