Upgrade_watchdog #401
Merged
Upgrade_watchdog #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 75.83% 75.87% +0.04%
==========================================
Files 68 68
Lines 7254 7254
==========================================
+ Hits 5501 5504 +3
+ Misses 1753 1750 -3 ☔ View full report in Codecov by Sentry. |
samaloney
reviewed
Oct 7, 2024
samaloney
approved these changes
Nov 13, 2024
setup.cfg
Outdated
| @@ -28,7 +28,7 @@ install_requires = | |||
| scp | |||
| spiceypy | |||
| sunpy>=4.0.1 | |||
| watchdog | |||
| watchdog==5.0.3 | |||
There was a problem hiding this comment.
Suggested change
| watchdog==5.0.3 | |
| watchdog>=5.0.3 |
| assert soop_manager.filecounter == 4 | ||
| assert len(soop_manager.soops) == 129 | ||
| assert len(soop_manager.observations) == 132 | ||
| # if platform.system() != "Darwin": |
There was a problem hiding this comment.
Suggested change
| # if platform.system() != "Darwin": |
nicHoch
force-pushed
the
upgrade_watchdog
branch
from
dfd5660 to
77ff261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.