php8: added property in constructor #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for creating the parameters and identifiers has been moved to the Builder.NewParameter and Builder.NewIdentifier methods. The grammar rules 'is_reference' and 'is_variadic' have been renamed to 'optional_arg_ref' and 'optional_ellipsis' as in PHP-Parser. Added a new grammar rule 'optional_visibility_modifier' to describe visibility modifiers for properties.
added 2 commits
July 27, 2021 22:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for creating the parameters and identifiers has been
moved to the
Builder.NewParameterandBuilder.NewIdentifiermethods.The grammar rules
is_referenceandis_variadichave been renamedto
optional_arg_refandoptional_ellipsisas in PHP-Parser.Added a new grammar rule
optional_visibility_modifierto describevisibility modifiers for properties.
Fixes #32