refactor: separate port and address in Server struct for flexibility #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `port` field to `Server` struct to store the port separately from `addr`. - Modified `NewServer` to initialize the `port` field instead of setting `addr` directly. - Introduced `setAddr` method to handle address formatting based on port, with a fallback to port `0` if unspecified. - Improved readability and separation of concerns by distinguishing port from the full address.
i9si
approved these changes
Sep 20, 2024
- adding a return statement to ensure that if s.port is empty, the method exits early without modifying s.addr. This improves the logic by preventing unnecessary assignments and enhances code readability.
…ogic - implemented a unit test for the setAddr method to ensure it correctly handles both cases: when a valid port is provided and when the port is empty. This prevents future regressions by confirming that s.addr is only modified as intended.
i9si
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
portfield toServerstruct to store the port separately fromaddr.NewServerto initialize theportfield instead of settingaddrdirectly.setAddrmethod to handle address formatting based on port, with a fallback to port0if unspecified.