#3427 - Treat manifest warnings as warnings (#3429)

* feat: treat warnings as warnings during aapt2 build * test: add invalid fragment to manifest to confirm warning
iBotPeaches · Nov 16, 2023 · 72d0bc1 · 72d0bc1
1 parent bf1041e
commit 72d0bc1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/brut.apktool/apktool-lib/src/main/java/brut/androlib/AaptInvoker.java b/brut.apktool/apktool-lib/src/main/java/brut/androlib/AaptInvoker.java
@@ -178,6 +178,9 @@ private void invokeAapt2(File apkFile, File manifest, File resDir, File rawDir,
 
         cmd.add("--no-compile-sdk-metadata");
 
+        // #3427 - Ignore stricter parsing during aapt2
+        cmd.add("--warn-manifest-validation");
+
         if (mApkInfo.sparseResources) {
             cmd.add("--enable-sparse-encoding");
         }

diff --git a/brut.apktool/apktool-lib/src/test/resources/aapt2/testapp/AndroidManifest.xml b/brut.apktool/apktool-lib/src/test/resources/aapt2/testapp/AndroidManifest.xml
@@ -6,6 +6,7 @@
                 android:name="android.accessibilityservice"
                 android:resource="@xml/accessibility_service_config" />
         </service>
+        <fragment android:name=".views.Issue3427"/>
         <meta-data name="test_int_as_string" value="\ 12345" />
         <meta-data name="test_int" value="12345" />
     </application>