Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Whatsapp (since Version 2-22-23-15) cannot be decompiled properly #2933

Closed
sickalot opened this issue Nov 13, 2022 · 8 comments · Fixed by #2936
Closed

[BUG] - Whatsapp (since Version 2-22-23-15) cannot be decompiled properly #2933

sickalot opened this issue Nov 13, 2022 · 8 comments · Fixed by #2936
Assignees
Labels

Comments

@sickalot
Copy link

Information

  1. Apktool Version - 2.6.1
  2. Operating System - Windows
  3. APK From? https://whatsapp-messenger.de.uptodown.com/android/download
  4. APK From? https://play.google.com/store/apps/details?id=com.whatsapp&hl=de&gl=US
  5. Before Version 2-22-23-15 decompiling worked
  6. Since Version 2-22-23-15 this issue occurs

Stacktrace/Logcat

Include stacktrace here
I: Using Apktool 2.6.1 on whatsapp-messenger-2-22-24-18.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: C:\Users\....\AppData\Local\apktool\framework\1.apk
I: Regular manifest package...
I: Decoding file-resources...
S: Could not decode file, replacing by FALSE value: cr.xml
S: Could not decode file, replacing by FALSE value: cg8.xml
S: Could not decode file, replacing by FALSE value: ckr.xml
S: Could not decode file, replacing by FALSE value: bh5.png
S: Could not decode file, replacing by FALSE value: l0.png
S: Could not decode file, replacing by FALSE value: og.png
S: Could not decode file, replacing by FALSE value: vn.png
S: Could not decode file, replacing by FALSE value: lc.png
S: Could not decode file, replacing by FALSE value: b0r.png
S: Could not decode file, replacing by FALSE value: bbd.9.png
S: Could not decode file, replacing by FALSE value: lw.9.png
S: Could not decode file, replacing by FALSE value: 4e.png

[...]

S: Could not decode file, replacing by FALSE value: csr.xml
S: Could not decode file, replacing by FALSE value: b9q.png
S: Could not decode file, replacing by FALSE value: bzx.png
S: Could not decode file, replacing by FALSE value: b3f.png
S: Could not decode file, replacing by FALSE value: bay.png
I: Decoding values */* XMLs...
I: Baksmaling classes.dex...
I: Baksmaling classes2.dex...
I: Baksmaling classes3.dex...
I: Baksmaling classes4.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
I: Copying META-INF/services directory

### Steps to Reproduce
1.  java -jar apktool.jar d whatsapp-messenger-2-22-24-18.apk

### Frameworks
-

### APK
https://whatsapp-messenger.de.uptodown.com/android
https://play.google.com/store/apps/details?id=com.whatsapp&hl=de&gl=US

### Questions to ask before submission
1. Have you tried `apktool d`, `apktool b` without changing anything?
Yes

2. If you are trying to install a modified apk, did you resign it?
I only try to decompile it

3. Are you using the latest apktool version?
Yes

@iBotPeaches
Copy link
Owner

Hmm an r and R and res.

Didn't expect this. Let me think on this, I think I can patch this easily.

@iBotPeaches
Copy link
Owner

➜  2933 apktool d whatsapp-messenger-2-22-24-18.apk -f
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true
I: Using Apktool 2.6.2-eb105f-SNAPSHOT on whatsapp-messenger-2-22-24-18.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: /home/ibotpeaches/.local/share/apktool/framework/1.apk
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Baksmaling classes.dex...
I: Baksmaling classes2.dex...
I: Baksmaling classes3.dex...
I: Baksmaling classes4.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
I: Copying META-INF/services directory
➜  2933 

Disassembly should be good. Building is another story, but I believe an existing ticket with proguard/resproguard.

@sickalot
Copy link
Author

Thank you
Sorry, I am not a developer, and I am not sure if I understood correctly. Is this fixed (Which version) or will this be fixed in a future version?

@iBotPeaches
Copy link
Owner

Thank you Sorry, I am not a developer, and I am not sure if I understood correctly. Is this fixed (Which version) or will this be fixed in a future version?

2.6.2 - expected before end of year.

@sickalot
Copy link
Author

I see, thank you very much. Looking forward for it.

Is there any way to have a chat with you?
I would like to explain the purpose of decoding whatsapp.
Google wont help here, its too specific, unfortunately.

If you dont have time for this, I totally understand :D
But you maybe could save me a lot of time i might waste otherwise trying to get things running that will not work
thanks

@sickalot
Copy link
Author

I tried v.2.7.0 and had no errors.
But I still have data like this below.

Is there anything I can do to avoid "Dummies"?

#ff000000 #ffffffff #ff7fa87f @android:color/black @android:color/black #ff112d2e @color/APKTOOL_DUMMYVAL_0x7f0606a5 @color/APKTOOL_DUMMYVAL_0x7f060453 @color/APKTOOL_DUMMYVAL_0x7f060695 @color/APKTOOL_DUMMYVAL_0x7f06069d @color/APKTOOL_DUMMYVAL_0x7f060461 @color/APKTOOL_DUMMYVAL_0x7f060702 @color/APKTOOL_DUMMYVAL_0x7f060453 @color/APKTOOL_DUMMYVAL_0x7f060321 @color/APKTOOL_DUMMYVAL_0x7f060322 @color/APKTOOL_DUMMYVAL_0x7f060453 @color/APKTOOL_DUMMYVAL_0x7f06045d @color/APKTOOL_DUMMYVAL_0x7f06045d @color/APKTOOL_DUMMYVAL_0x7f06069d @color/APKTOOL_DUMMYVAL_0x7f0606ee @color/APKTOOL_DUMMYVAL_0x7f060468 @null @color/APKTOOL_DUMMYVAL_0x7f060687 #ff008069 @color/APKTOOL_DUMMYVAL_0x7f0606a0 @color/APKTOOL_DUMMYVAL_0x7f0606d2 @color/APKTOOL_DUMMYVAL_0x7f0606fc

@iBotPeaches
Copy link
Owner

I tried v.2.7.0 and had no errors. But I still have data like this below.

Is there anything I can do to avoid "Dummies"?

No, we need those resources because the human-readable name of the resource is missing so we make up our own.

@teamb58
Copy link

teamb58 commented Jan 2, 2023

I tried v.2.7.0 and had no errors. But I still have data like this below.
Is there anything I can do to avoid "Dummies"?

No, we need those resources because the human-readable name of the resource is missing so we make up our own.

Hi @iBotPeaches ,
Question on similar lines. These dummy entries were not there is past versions. Now, when I try out the old apk file(which used to work previously), they also produce these dummy variables.

Problem is, it's becoming difficult to identify the actual resource it's pointing to while doing backtracking from smali files.

Taking reference from #2970 (comment), the features states something like Additional features that can fix some Apktool errors, such as removing DUMMY_APKTOOL, clear framework before decompiling. So, is there anything you could do with this issue please?

If I have misunderstood your statement, could you please elaborate on this issue?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants