-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds broken - July 19, 2023 #3174
Comments
Looks like JDK 11 & 17 failed |
This is escaping me. I've got no idea at present. I've:
Nothing is adding up |
I was able to reproduce the issue locally. It is indeed caused by JDK 17.0.8. The following is mentioned in the changelog:
The tests passed after using the system property within the test block in build.gradle: test {
systemProperty 'jdk.util.zip.disableZip64ExtraFieldValidation', 'true'
testLogging {
exceptionFormat = 'full'
}
} Not sure what would be the next step from there. But I hope this helps! |
thanks @evowizz - that is indeed it. Thanks for your tip/help |
JDK 20 was causing issues for codesearch. Includes a work-around (added jvm flag) to disable an exception about invalid zip file headers. Found this via: iBotPeaches/Apktool#3174 (comment) Bug: b/291804782 Change-Id: I743664ace22c035a6957b46a4df9918cedb59ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4705883 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/main@{#1173508}
JDK 20 was causing issues for codesearch. Includes a work-around (added jvm flag) to disable an exception about invalid zip file headers. Found this via: iBotPeaches/Apktool#3174 (comment) Bug: b/291804782 Change-Id: I743664ace22c035a6957b46a4df9918cedb59ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4705883 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/main@{#1173508} NOKEYCHECK=True GitOrigin-RevId: edddc72945918f04458ef0c556f22753069ca18e
Just a note: calling The Java developers were so "intelligent" to check this property at load-time of
As the Java class loaders use ZIPFile class to load the Jar files from class path, ZipFile class is loaded long before any user created class respectively the main class is loaded. Therefore I don't see a way how a call to This affects all users who directly execute aktool from command-line. For exemple if you execute apktool 2.8.1 on library.apk
You will still run into |
thanks @jpstotz. Here is the commit I tracked down when I was researching this. openjdk/jdk@fff7e1a |
JDK 20 was causing issues for codesearch. Includes a work-around (added jvm flag) to disable an exception about invalid zip file headers. Found this via: iBotPeaches/Apktool#3174 (comment) Bug: b/291804782 Change-Id: I743664ace22c035a6957b46a4df9918cedb59ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4705883 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/main@{#1173508} CrOS-Libchrome-Original-Commit: edddc72945918f04458ef0c556f22753069ca18e
I'm having the same problem in another project. My question is if it should be the way to solve the problem. I mean did they add an extra validation in new JDK for us to disable? |
I am not familiar with java but I thought it could be interesting for people hitting this issue on the command line to know that the following workaround works
|
Somehow builds are all failing, even old ones.
https://github.com/iBotPeaches/Apktool/actions/runs/5586823977/jobs/10238074452
The text was updated successfully, but these errors were encountered: