fix: decoding references to private resources #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved the workfun to run. I remember reverting this fix a few years ago because I improperly added it to ALL resources, this seems like a safer version. |
iBotPeaches
reviewed
Sep 7, 2021
brut.apktool/apktool-lib/src/main/java/brut/androlib/res/data/ResResSpec.java
Outdated
Show resolved
Hide resolved
iBotPeaches
previously approved these changes
Sep 9, 2021
|
Do you have a good idea of a way we can test this in our test suite? Like finding a resource that should remain private and adding it to colors.xml? Then testing to make sure it comes out with the asterisk? |
RachelZoieJovie97
previously approved these changes
Oct 5, 2021
|
@MrIkso ping here. I am curious if you have a good idea for a test so we don't regress this. |
MrIkso
dismissed stale reviews from RachelZoieJovie97 and iBotPeaches
via
33f6d46
|
@iBotPeaches even thought of this for the test... |
iBotPeaches
approved these changes
Oct 17, 2021
|
thanks! |
|
This is fixed in aapt/aapt2 https://github.com/pashamcr/AAPTS/tree/windows, and works without this fix with #2637 , |
sakibguy
added a commit
to sakibguy/Apktool
that referenced
this pull request
Oct 19, 2021
fix: decoding references to private resources (iBotPeaches#2650)
iBotPeaches
added a commit
that referenced
this pull request
Mar 21, 2022
This reverts commit d294111.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #2033, fixed #2637 of error
error: resource <name> is private.Use
*before resource name if rererence to private resources.Expample:
before fix
<color name="gm3_ref_palette_dynamic_tertiary900">@android:color/Indigo_700</color>after fix
<color name="gm3_ref_palette_dynamic_tertiary900">@*android:color/Indigo_700</color>