Replace use of deprecated methods with their recommended replacements #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iBotPeaches
requested changes
Dec 10, 2021
There was a problem hiding this comment.
Thanks for PR! Appears this broke the Proguard portion of the build.
> Task :brut.apktool:apktool-cli:proguard
Warning: org.apache.commons.text.lookup.ScriptStringLookup: can't find referenced class javax.script.ScriptEngineManager
Warning: org.apache.commons.text.lookup.ScriptStringLookup: can't find referenced class javax.script.ScriptEngineManager
Warning: org.apache.commons.text.lookup.ScriptStringLookup: can't find referenced class javax.script.ScriptEngineManager
Warning: org.apache.commons.text.lookup.ScriptStringLookup: can't find referenced class javax.script.ScriptEngine
Warning: org.apache.commons.text.lookup.ScriptStringLookup: can't find referenced class javax.script.ScriptEngine
Warning: org.apache.commons.text.lookup.ScriptStringLookup: can't find referenced class javax.script.ScriptEngine
Warning: org.apache.commons.text.lookup.ScriptStringLookup: can't find referenced class javax.script.ScriptEngine
|
Yup, sorry for the noise. I've pushed a fix commit which adds the |
pashamcr
reviewed
Dec 11, 2021
iBotPeaches
approved these changes
Dec 13, 2021
|
thanks! |
iBotPeaches
added a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of methods of moved to the commons-lang project, so here's a PR to get them from their new home.