Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes facebook apk deconstruction #2884

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

tvildo
Copy link
Contributor

@tvildo tvildo commented Sep 19, 2022

Fixes ApkTool can't deconstruct apk: https://apkpure.com/facebook/com.facebook.katana
fixes #1719

@iBotPeaches
Copy link
Owner

This to trick the handling of like styles# etc? What stops this from just becoming an infinite list of a res type a number suffix?

Perhaps I'll accept this, but I want to double check all the resource types in FB.

@tvildo
Copy link
Contributor Author

tvildo commented Sep 19, 2022

I tried to extract Facebook APK without success, because it contains style resource named as style.2, so instead of matching exactly on resource name I matched with prefix.

Jadx handles same thing with success: https://github.com/skylot/jadx/blob/78aadda931dfa842479083c2e69868121ebc89cf/jadx-core/src/main/java/jadx/core/xmlgen/ResTableParser.java#L338

@iBotPeaches iBotPeaches merged commit 5d6c6c0 into iBotPeaches:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decompiling latest Facebook APK - unsupported res type name for bags. Found: style2
2 participants