Deprecated SnakeYAML methods #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I replaced the deprecated methods in SnakeYAML 1.33 with the respective non-deprecated constructor calls. These are equivalent: The deprecated non-arg constructor of Constructor https://bitbucket.org/snakeyaml/snakeyaml/src/snakeyaml-1.33/src/main/java/org/yaml/snakeyaml/constructor/Constructor.java calls https://bitbucket.org/snakeyaml/snakeyaml/src/7f5106920d7754ecab734725ba577083e55c7204/src/main/java/org/yaml/snakeyaml/constructor/SafeConstructor.java#lines-52, which uses a new empty LoaderOptions() Similarly, SafeRepresenter https://bitbucket.org/snakeyaml/snakeyaml/src/7f5106920d7754ecab734725ba577083e55c7204/src/main/java/org/yaml/snakeyaml/representer/SafeRepresenter.java#lines-54 uses a new empty DumperOptions.
|
Thanks - Java is confusing in this aspect. Not following how a deprecated method, if I never extended it - requires these changes. |
iBotPeaches
approved these changes
May 27, 2023
iBotPeaches
approved these changes
May 27, 2023
|
thanks! |
iBotPeaches
added a commit
that referenced
this pull request
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the deprecated methods in SnakeYAML 1.33 with the respective non-deprecated constructor calls. These are equivalent:
The deprecated non-arg constructor of Constructor https://bitbucket.org/snakeyaml/snakeyaml/src/snakeyaml-1.33/src/main/java/org/yaml/snakeyaml/constructor/Constructor.java calls https://bitbucket.org/snakeyaml/snakeyaml/src/7f5106920d7754ecab734725ba577083e55c7204/src/main/java/org/yaml/snakeyaml/constructor/SafeConstructor.java#lines-52, which uses a new empty LoaderOptions()
Similarly, SafeRepresenter https://bitbucket.org/snakeyaml/snakeyaml/src/7f5106920d7754ecab734725ba577083e55c7204/src/main/java/org/yaml/snakeyaml/representer/SafeRepresenter.java#lines-54 uses a new empty DumperOptions.