fix: skip parsing if chunk end is reached within table chunk #3134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3036
This cannot be a valid application, but the
entriesCount
seems to be lying. We exceed the chunk size before we are done reading the items. This makes sense in a way because ending the chunk reading when limit is fixed - does correct parsingHowever, I am confused how tools like arscblamer, android studio, etc are reading all assets with no skipping of chunks. So perhaps this data is somewhere else, but I'm not sure where. The spec states
https://github.com/aosp-mirror/platform_frameworks_base/blob/main/libs/androidfw/include/androidfw/ResourceTypes.h#L1228
I've confirmed: