fix: crash when decompiling framework-res.apk with a tag (regression) #3193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression since 2.8.0 that causes apktool to crash when decompiling framework-res.apk (which has no other framework dependencies) with the -t tag option:
This is caused by the fact that
mApkInfo.usesFramework
isnull
if there are no framework dependencies for a given APK (which is true for any base framework, i.e. framework-res.apk), and then doingmApkInfo.usesFramework.tag = mConfig.frameworkTag;
inResourcesDecoder
, causing aNullPointerException
.How wasn't it caught during development? Perhaps due to the previous framework loading regression that recently got fixed, that loaded frameworks with arbitrary IDs, which caused
UsesFramework
to always be created becauseids
array was never empty, even when it should have been.And so:
ResourcesDecoder.decodeResources
rather thanResTable.initApkInfo
that has reference to theConfig
object as well.mConfig.frameworkTag
, because if it'snull
theninfo.tag
(which is alreadynull
by default) will simply be set tonull
again.