Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardened String Block Parser #3239

Merged
merged 9 commits into from
Aug 1, 2023
Merged

Hardened String Block Parser #3239

merged 9 commits into from
Aug 1, 2023

Conversation

iBotPeaches
Copy link
Owner

@iBotPeaches iBotPeaches commented Jul 31, 2023

  • Supports when string block header is packed w/ extra data.
  • Supports when string block has style count == 0, but style offset > 0
  • Supports when extra data remaining after reading strings or styles
  • Supports when string block has more strings than can fit

fixes: #3236

@iBotPeaches
Copy link
Owner Author

Nevermind - this isn't ready. Regressed the sample app with style count = 0, but style offset > 0.

@iBotPeaches
Copy link
Owner Author

07-31 05:44:57.579 283041 283041 W ResourceType: Bad string block: string #316 entry is at 6488080, past end at 21420

Missing one more patch. Need to handle when string block has more strings reported than can fit.

@iBotPeaches iBotPeaches marked this pull request as ready for review August 1, 2023 00:59
@iBotPeaches iBotPeaches merged commit 7c2cb5b into master Aug 1, 2023
31 checks passed
@iBotPeaches iBotPeaches deleted the string-block-robust branch August 1, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid chunk type (1402) - AndroidManifest
1 participant