in the ApkDecoder use apkFile and unknownFiles from ApkInfo #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @IgorEisberg or you to the refactors so we can all peek each other's. |
iBotPeaches
reviewed
Jul 31, 2023
iBotPeaches
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Tested it out. Looked for 2 things.
- If the move for unknown files still worked - it did
- If the file was properly closed after being set to an intermediate variable - it did
Somehow we are leaking a file close handler, but looks unrelated to this. I'll dig into that later.
|
thanks! |
iBotPeaches
added a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApkDecoder and ResourceDecoder - use apkFile from ApkInfo