fix: support decoding application with duplicate res entries #3252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2824
In the sample above. We find a duplicate resource at end of chunk.
The last entry has the same index to the previous and malformed. The size reported is also wrong. There are still 8 bytes, but its a duplicate entry.
I've debated a few paths.
In this patch we return early from value read if size less than 8, fallback to null and let the end chunk reading (read vs actual) skip what is remaining.