Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Disassembly of mega old Android (M5) #3325

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Support Disassembly of mega old Android (M5) #3325

merged 1 commit into from
Sep 11, 2023

Conversation

iBotPeaches
Copy link
Owner

@iBotPeaches iBotPeaches commented Sep 10, 2023 •
edited

fixes: #3311

--

F: Chunk #1 start: type=0x0002 chunkSize=0x0002c8fc
F: Chunk #2 start: type=0x0001 chunkSize=0x00010f84
F: Chunk #3 start: type=0x0200 chunkSize=0x0001b96c
F: Chunk #4 start: type=0x0201 chunkSize=0x00003b80

The sample included in #3311 is from 2008 Milestone Android builds, which is pre-1.0. Prior to any API stabilization so we can see that they don't have TYPE_SPECS. We can survive disassembly by just making types on the fly if we didn't find one.

@iBotPeaches iBotPeaches changed the title Support mega old Android (API 5) Support mega old Android (M5) Sep 10, 2023
@iBotPeaches iBotPeaches changed the title Support mega old Android (M5) Support Disassembly of mega old Android (M5) Sep 10, 2023
@iBotPeaches iBotPeaches marked this pull request as ready for review September 10, 2023 23:09
@iBotPeaches iBotPeaches merged commit c07e4a9 into master Sep 11, 2023
31 checks passed
@iBotPeaches iBotPeaches deleted the issue-3311 branch September 11, 2023 10:24
@iBotPeaches iBotPeaches added this to the v2.9.0 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9.0
1 participant
@iBotPeaches