-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker support #3351
Add Docker support #3351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I'll accept this and merge it. Just some comments/suggestions first.
I think I've covered all the suggested optimizations, let me know if there's anything else! |
I tried to build this locally and it could never complete due to the license approval. I see you have code to approve this, so a bit lost why its not auto approving these license agreements.
|
That's.. odd. What OS and docker version? Maybe I can reproduce. |
Just my Kali laptop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I upgraded my machine, rebooted and its all good now. If the CI pipeline starts failing we can investigate further.
Dockerfile
for full build support includingapktool
,zipalign
, andapksigner
DOCKER.md
for full documentationDOCKER.md
inREADME.md
Once this PR is merged, I'd be happy to help set up a GitHub Workflow to automatically build a
ghcr.io/apktool:latest
on merges into the main branch, and update the documentation to reflect that users can just pull the image vs building it themselves.