Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added auto-build of docker image #3361

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Added auto-build of docker image #3361

merged 6 commits into from
Oct 3, 2023

Conversation

Fmstrat
Copy link
Contributor

@Fmstrat Fmstrat commented Oct 2, 2023

  • Workflow for building :<hash> and :latest images and pushing to ghcr.io on release
  • Updated instructions for pull
  • Could consider updating to use the locally built JAR in the build.yml and including a :beta release on PRs into master in the future

NOTE: I have no real way to test this when integrated into the repo. It is modeled after successful local builds.

@Fmstrat Fmstrat changed the title Feature/docker build Added auto-build of docker image Oct 2, 2023
iBotPeaches
iBotPeaches reviewed Oct 2, 2023
View reviewed changes
Copy link
Owner

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - some comments about tag/version.

.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
iBotPeaches
iBotPeaches reviewed Oct 2, 2023
View reviewed changes
.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
@iBotPeaches iBotPeaches merged commit 448440b into iBotPeaches:master Oct 3, 2023
30 checks passed
@iBotPeaches
Copy link
Owner

thanks!

@iBotPeaches iBotPeaches added this to the v2.9.0 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iBotPeaches iBotPeaches iBotPeaches approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fmstrat @iBotPeaches