-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for PR builds on master #3363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible to use layer/targets? Want to avoid becoming one of those projects that has like 15 Dockerfile files in root.
docker/build-push-action@v4
supports target
.
So the dockerfile could evolve into like:
- Base
- Beta
- Prod (?)
So we only have 1.
Yea, I actually started this using After that I reorganized the Dockerfile but I now notice the install can always happen last, so targets should now work. I'll shift there. EDIT: I also hate the fill-up of root, so you'll see I moved everything Docker related into EDIT 2: Hmm, the problem with |
There we go, a single Dockerfile. Releases will be a bit slower because they'll build, but not really a big deal, and we retain the smaller image size. I can test this more fully once #3362 is solved. |
Also, let me know if you'd prefer the beta workflow to be part of |
There is a good deal of duplication, but since the entry point is different (published release vs merged pr) - I imagine that'll be difficult. I'm guessing what might be easier is a composite workflow action we dump into |
Good point, that being said, it only triggers on a completed PR, so all the tests would have already run against the branch, so it probably doesn't actually matter. |
Updated to JDK/JRE 17 LTS. No longer blocked. |
:beta
Replaceopenjdk
withsapmachine
as the original repo is deprecated, and sapmachine is official nowibm-semeru-runtimes
(also official) for JDK/JRE 17 LTSHeld up by #3362