Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated grammar, punctuation, and formatting for some pages and updated the dependencies #3448

Merged
merged 14 commits into from
Nov 29, 2023

Conversation

Lonk12
Copy link

@Lonk12 Lonk12 commented Nov 28, 2023

also Added CodeSQL settings for analyzing and fixed linting errors

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@iBotPeaches
Copy link
Owner

Thanks! but I don't really want to add CodeQL for the frontend - it doesn't really scan markdown - it scans js/ts which amounts to like 3-5 files in the entire frontend.

The linting issues you encountered are already linted from the MDX format and I'm not aware of CodeQL offering any enhancement in that area.

@Lonk12
Copy link
Author

Lonk12 commented Nov 29, 2023

Thanks! but I don't really want to add CodeQL for the frontend - it doesn't really scan markdown - it scans js/ts which amounts to like 3-5 files in the entire frontend.

The linting issues you encountered are already linted from the MDX format and I'm not aware of CodeQL offering any enhancement in that area.

I removed it for you, do you want me to change anything else?

@iBotPeaches iBotPeaches merged commit ae97d35 into iBotPeaches:docs Nov 29, 2023
1 check passed
@iBotPeaches
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants