Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing stream closing #3634

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

azotzot
Copy link
Contributor

@azotzot azotzot commented Jul 5, 2024

Noticed that when used as a library, you can't delete or rename the manifest file. This fix, should solve the problem.

Here is an example of an error that can happen.
image

Copy link
Owner

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One comment about re-using Apache commons instead of a new private func.

@azotzot azotzot requested a review from iBotPeaches July 8, 2024 08:12
@iBotPeaches iBotPeaches merged commit 1542fd0 into iBotPeaches:master Jul 8, 2024
25 checks passed
@iBotPeaches
Copy link
Owner

thanks!

@iBotPeaches iBotPeaches added the Bug label Jul 8, 2024
@iBotPeaches iBotPeaches added this to the v2.10.0 milestone Jul 8, 2024
iBotPeaches added a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants