Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubo-rpc-client v3 to v4 #341

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Bump kubo-rpc-client v3 to v4 #341

merged 1 commit into from
Aug 8, 2024

Conversation

cedric25
Copy link
Contributor

@cedric25 cedric25 commented Aug 8, 2024

Why?

PR on kubo's side: ipfs/js-kubo-rpc-client#221

Especially:

Remove legacy ipfs-core-types and ipfs-utils dependencies

Which does some magic trying to find the correct fetch implementation, which seems to break usage of our SDK in Next.js SSR.


Same PR for web3mail-sdk: iExecBlockchainComputing/web3mail-sdk#152

Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cedric25 cedric25 merged commit ef5dc92 into v2 Aug 8, 2024
2 checks passed
@cedric25 cedric25 deleted the feature/bump-kubo branch August 8, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants