Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible when load skin #257

Merged
merged 8 commits into from
Feb 20, 2023

Conversation

nurrifqialhusaini
Copy link
Contributor

I had an experience when a player was setting a skin for the first time and then the server did a restart/shutdown. When players re-join the server they are invisible, and it is very unsettling. I've fixed it, please try

@nurrifqialhusaini
Copy link
Contributor Author

Hello, i make the PR again for blacklisting ped access with citizenids, i hope this is useful

client/framework/esx/compatibility.lua Outdated Show resolved Hide resolved
game/customization.lua Outdated Show resolved Hide resolved
shared/config.lua Outdated Show resolved Hide resolved
@TheiLLeniumStudios
Copy link
Member

@nurrifqialhusaini Thank you for the PR. There's a lot of duplicated and its not ideal the way it is done right now. I have requested changes. Please go through all of them and make those changes and then I will review it again

@TheiLLeniumStudios
Copy link
Member

LGTM now. Thanks @nurrifqialhusaini

@TheiLLeniumStudios TheiLLeniumStudios merged commit 980f511 into iLLeniumStudios:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants