-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invisible when load skin #257
Merged
TheiLLeniumStudios
merged 8 commits into
iLLeniumStudios:main
from
nurrifqialhusaini:main
Feb 20, 2023
Merged
Fix invisible when load skin #257
TheiLLeniumStudios
merged 8 commits into
iLLeniumStudios:main
from
nurrifqialhusaini:main
Feb 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, i make the PR again for blacklisting ped access with citizenids, i hope this is useful |
TheiLLeniumStudios
requested changes
Feb 20, 2023
@nurrifqialhusaini Thank you for the PR. There's a lot of duplicated and its not ideal the way it is done right now. I have requested changes. Please go through all of them and make those changes and then I will review it again |
TheiLLeniumStudios
requested changes
Feb 20, 2023
LGTM now. Thanks @nurrifqialhusaini |
TheiLLeniumStudios
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an experience when a player was setting a skin for the first time and then the server did a restart/shutdown. When players re-join the server they are invisible, and it is very unsettling. I've fixed it, please try