Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ace permissions #389

Merged
merged 3 commits into from
Feb 4, 2024
Merged

Conversation

Manason
Copy link
Contributor

@Manason Manason commented Feb 3, 2024

Rather than use console prints of all possible ace permissions, introducing a config option for the user to specify all the ace permissions to check against. This supports dynamic permission assignment using ox_lib ACL, as the ace permission may not be assigned to any players on server start.

An even better follow-up step from this PR might be to pull the list of ace permissions to check against from the various blacklist configs rather than duplicate the list in a different part of config. But this is a simpler stop-gap solution than current main

@TheiLLeniumStudios
Copy link
Member

Makes sense. What I did was overkill and unnecessary.

I'll merge the PR. Feel free to add in the improvement that you mentioned which is gonna fetch all the used aces from the blacklist config in a followup PR if you can. Otherwise I'll see if I can add it when I have time.

Thanks again for the contribution

@TheiLLeniumStudios TheiLLeniumStudios merged commit e3bd119 into iLLeniumStudios:main Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants