Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated: sanitizeRoomName #47

Open
iLPdev opened this issue Jun 25, 2020 · 1 comment
Open

Deprecated: sanitizeRoomName #47

iLPdev opened this issue Jun 25, 2020 · 1 comment
Labels
question Further information is requested

Comments

@iLPdev
Copy link
Owner

iLPdev commented Jun 25, 2020

As far as I can see, there's really no need for trimming lines from Discworld's ASCII map. Even if the user has options display set to left on the game, discMapper is pulling room titles directly from GMCP now - there's never going to be anything to sanitize. If it's not called anywhere else, we should just remove the whole thing rather than comment it out, right?
@iLPdev iLPdev added the question Further information is requested label Jun 25, 2020
@iLPdev
Copy link
Owner Author

iLPdev commented Jul 8, 2020

This is still in #69 but, certainly, if no bug reported in beta, then it can be whacked before v1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iLPdev