Release v0.2.0-beta #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
every little bit of documentation helps, i suppose. ain't that right, @all-contributors
when a new room is detected by the exit trigger, set the room name via GMCP
There is no longer a need to parse through text lines looking for the room name, so handle_exits is no longer calling this function.
in the event that name_search is being called elsewhere than handle_exits, this will throw the debug echo to announce the occurance.
short exits and exit stubs can be set internally
getRoomIDbyHash(gmcp.room.info.identifier) can happen with check_room or fine_me or somewhere like that -- maybe even just right there in handle_exits.
I already removed the call to this function, so it's no longer needed. I don't believe it was called anywhere else.
custom_locator is no longer used for grabbing roomID hash
this is where Jor'Mox may have been having problems
GMCP identifier is unique for each room whereas room names (even gmcp.room.info.name) are not.
It should only create rooms if there is no roomID in the table for any given GMCP hash sent by the server (== -1)
This reverts commit 41bd0a9.
This reverts commit 6c18677.
This reverts commit 17a3119.
For some unknown reason, the template from [gitignore.io](https://gitignore.io) excludes several files within the .vscode directory... which defeats `.vscode/*`. I've rmeoved those exclusions and also explicitly ignored the folder itself.
bring in Initial Help System Update
Merge branch 'develop' into feature/help-system
|
bah. ridiculousness. @all-contributors, add @iLPdev for code, design, doc, infra, maintenance, and projectmanagement of the beta release. |
|
really? no second chances, @all-contributors ??? please add @iLPdev for code, design, doc, infra, maintenance, and projectmanagement |
|
I've put up a pull request to add @iLPdev! 🎉 |
This was referenced Jul 8, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.