Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New unit types: force, power, and pressure #333

Merged
merged 17 commits into from
Feb 16, 2022
Merged

New unit types: force, power, and pressure #333

merged 17 commits into from
Feb 16, 2022

Conversation

ehoogerbeets
Copy link
Contributor

@ehoogerbeets ehoogerbeets commented Feb 10, 2022 •
edited by gouniLee
Loading

Checklist

  • At least one test case is included for this feature or bug fix.
  • ReleaseNotes has added or is not needed.
  • This PR has passed all of the test cases on Nodejs and Chrome Browser.
  • This PR has passed all of the test cases on QT/QML.
  • This is an API breaking change.
  • Requires a major version change.

Issue Resolved / Feature Added

Resolution

Links

@ehoogerbeets ehoogerbeets self-assigned this Feb 10, 2022
gouniLee
gouniLee reviewed Feb 14, 2022
View reviewed changes
js/lib/PowerUnit.js Show resolved Hide resolved
js/test/units/testPressure.js Outdated Show resolved Hide resolved
@ehoogerbeets
Copy link
Contributor Author

Okay ready for re-review

gouniLee
gouniLee reviewed Feb 15, 2022
View reviewed changes
js/lib/ForceUnit.js Show resolved Hide resolved
js/lib/ForceUnit.js Show resolved Hide resolved
@ehoogerbeets ehoogerbeets merged commit bfc5a11 into development Feb 16, 2022
@ehoogerbeets ehoogerbeets deleted the newUnitTypes branch February 16, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouniLee gouniLee gouniLee approved these changes

Assignees

@ehoogerbeets ehoogerbeets

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehoogerbeets @gouniLee