-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate batch 1 of independent ilib packages into the monorepo #46
Draft
wadimw
wants to merge
363
commits into
main
Choose a base branch
from
batch-independent-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to v14.6.1 of ilib
Update to v14.6.2 of ilib
Update to ilib v14.7.0
- use ilib-env as external - move webpacked output to lib/ilib-locale-web.js which is now also published in the npm package
Extract locale parser/formatter from ilib into a separate package
Minify and strip comments from web version
- converted to ES6 code - copied locale data as well
- added a description of all of the functions
- instead of making a CType namespace, just export the functions directly - fixed all of the callers to use these functions as well
Artifact of the copy
Update to v14.8.0
Copied code from ilib v14.8.0
Update to ilib v14.9.0
... and not the es6 one, which seems to screw up webpack when you import this package.
* Removed build calls from test scripts * Updated web test suite build to ouptut to a separate directory * Removed unnecessary locale list reconstruction
* Removed build calls from test scripts * Updated web test suite build to ouptut to a separate directory * Removed unnecessary locale list reconstruction * Added missing devdependency to data generation script
…d locale type handling issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the following packages:
ilib-commonalready addedilib-envalready addedChecklist:
prepare
scripts and devDependencies, readdjest
to devDependencies directlypnpm
instead ofnpm
build
is present (if applicable) and runs everything that's needed for publishing the packagetest
script is present and runs all unit testsbuild
jest
binstub calls in scriptsjest
(and related) to latest and rerun testsbuild
andtest
, thengit status
and optionally add untracked files to the monorepo root.gitignore
files
inpackage.json
lists only files that should be included in the published package, verify nothing's missing from package bundlesTODO before merge
[GUIDE]
commits from this PR to WIP Migration guide/script updates #47 and remove them from here (git rebase -i 2717a33
)TODO after merge