Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate batch 1 of independent ilib packages into the monorepo #46

Draft
wants to merge 363 commits into
base: main
Choose a base branch
from

Conversation

wadimw
Copy link
Contributor

@wadimw wadimw commented Dec 18, 2024

Adding the following packages:

  • ilib-address
  • ilib-casemapper
  • ilib-common already added
  • ilib-ctype
  • ilib-env already added
  • ilib-es6
  • ilib-istring
  • ilib-locale

Checklist:

  • Migrate repo as subtrees
  • Remove old ci config
  • Remove conditional-install from prepare scripts and devDependencies, readd jest to devDependencies directly
  • Link workspace packages
  • Validate package entrypoints
  • Ensure all scripts use pnpm instead of npm
  • Ensure build is present (if applicable) and runs everything that's needed for publishing the package
  • Ensure test script is present and runs all unit tests
  • Ensure no test script runs build
  • Replace jest binstub calls in scripts
  • Run tests for all affected packages and keep fixing until it works
  • Update jest (and related) to latest and rerun tests
  • Ensure scripts generate files to expected directories
  • Remove .gitignores from each package, re-run build and test, then git status and optionally add untracked files to the monorepo root .gitignore
  • Ensure files in package.json lists only files that should be included in the published package, verify nothing's missing from package bundles
  • Update changelogs to monorepo format; create test changeset and test automated changelog updates then revert both
  • Update links in package.json to point to the monorepo
  • Update links in documentation and source code to point to the monorepo
  • Ensure package is licensed under Apache-2.0
  • Create changeset and patchbump migrated packages with changelog message about migration
  • Regenerate lockfile and docs

TODO before merge

TODO after merge

  • Sync old tags
  • Push deprecation notices
  • Archive old repos

ehoogerbeets and others added 30 commits January 27, 2021 22:32
- use ilib-env as external
- move webpacked output to lib/ilib-locale-web.js which is now
  also published in the npm package
Extract locale parser/formatter from ilib into a separate package
Minify and strip comments from web version
- converted to ES6 code
- copied locale data as well
- added a description of all of the functions
- instead of making a CType namespace, just export the
functions directly
- fixed all of the callers to use these functions as well
Artifact of the copy
Copied code from ilib v14.8.0
Update to ilib v14.9.0
... and not the es6 one, which seems to screw up webpack when
you import this package.
* Removed build calls from test scripts
* Updated web test suite build to ouptut to a separate directory
* Removed unnecessary locale list reconstruction
* Removed build calls from test scripts
* Updated web test suite build to ouptut to a separate directory
* Removed unnecessary locale list reconstruction
* Added missing devdependency to data generation script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants