Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

no replacement of nonnumberic characters by _ in AndroidLayoutFile ma… #17

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

SilviaHT
Copy link
Collaborator

…keKey function

Copy link
Contributor

@ehoogerbeets ehoogerbeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code that is here looks pretty good. We still need the part in the localize method where we look up the translations by the key, and if it is not there, try again with the old key.

var unescaped = string;

while ((match = reUnicodeChar.exec(unescaped))) {
if (match && match.length > 1) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are unicode and octal escape sequences even valid in the Android layout xml files?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@ehoogerbeets
Copy link
Contributor

Also, we need to fix up the unit tests of course so that the build passes.

@ehoogerbeets
Copy link
Contributor

Silvia, are you still working on this one?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants