Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace ExceptionUtils module #40

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Namespace ExceptionUtils module #40

merged 3 commits into from
Dec 3, 2024

Conversation

frodsan
Copy link
Contributor

@frodsan frodsan commented Dec 3, 2024

Add a namespace to ExceptionUtils module instead of introduce it to the global namespace.

iMacTia
iMacTia approved these changes Dec 3, 2024
View reviewed changes
Copy link
Owner

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really good point, apologies for not realising it before the release 🙇

@iMacTia
Copy link
Owner

iMacTia commented Dec 3, 2024

@frodsan you'll need to update the requires as well (e.g. this one)

@frodsan
Copy link
Contributor Author

frodsan commented Dec 3, 2024

@iMacTia sorry about that, fixed 🙏

@iMacTia iMacTia merged commit 507b9fb into iMacTia:master Dec 3, 2024
6 checks passed
@frodsan frodsan deleted the fr/sidekiq-logging-exception-utils branch December 3, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frodsan @iMacTia