Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #10

Merged
merged 39 commits into from
Jan 18, 2024
Merged

Develop #10

merged 39 commits into from
Jan 18, 2024

Conversation

iMiMWeis
Copy link
Contributor

No description provided.

@iMiMWeis iMiMWeis requested a review from amenk November 27, 2023 14:36
amenk
amenk requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@amenk amenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes only, generally approved

src/Service/PasswordPathService.php Show resolved Hide resolved
src/Subscriber/CheckPasswordSubscriber.php Show resolved Hide resolved
src/Storefront/Controller/PasswordPageController.php Outdated Show resolved Hide resolved
iMiMWeis and others added 2 commits December 6, 2023 11:29
@iMiMWeis
#10 add tests
05ffc1a
@amenk
Add TEST_TOKEN=none for now
850d203 
* Plugin might not be acticated in the test DB
@amenk amenk merged commit a5b45de into main Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amenk amenk amenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iMiMWeis @amenk