Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve entity update after command execution, add retry logic #227

Merged
merged 33 commits into from
Sep 1, 2020
Merged

Improve entity update after command execution, add retry logic #227

merged 33 commits into from
Sep 1, 2020

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Aug 14, 2020 •
edited
Loading

Currently, the default execution is set to 10 seconds, which is terribly slow when turning on/off a light. It would be good to poll every second after a command is executed, until the execution is finished.

This will allow us to poll the event listener every minute or hour for installations where the remote is not / rarely used. By making it configurable via an Option Flow, users adjust it to their scenario.

What's changed

✨ Enhancement

  • Make scan interval configurable
  • Visually show if covers are opening or closing
  • Improve entity update speed after command execution via HA

🐛 Bug Fixes

  • Close client on error

Screenshot 2020-08-15 at 21 20 55

Screenshot 2020-08-20 at 14 33 24

@github-actions github-actions bot added the enhancement New feature or request label Aug 14, 2020
@iMicknl iMicknl linked an issue Aug 14, 2020 that may be closed by this pull request
Implement is_closing and is_opening for covers #181
Closed
@iMicknl iMicknl mentioned this pull request Aug 14, 2020
Closed
@iMicknl iMicknl requested a review from tetienne August 14, 2020 18:38
tetienne
tetienne requested changes Aug 14, 2020
View reviewed changes
custom_components/tahoma/__init__.py Outdated Show resolved Hide resolved
custom_components/tahoma/__init__.py Show resolved Hide resolved
custom_components/tahoma/__init__.py Show resolved Hide resolved
custom_components/tahoma/config_flow.py Show resolved Hide resolved
custom_components/tahoma/config_flow.py Show resolved Hide resolved
custom_components/tahoma/coordinator.py Outdated Show resolved Hide resolved
custom_components/tahoma/cover.py Outdated Show resolved Hide resolved
custom_components/tahoma/cover.py Outdated Show resolved Hide resolved
custom_components/tahoma/strings.json Outdated Show resolved Hide resolved
custom_components/tahoma/tahoma_device.py Show resolved Hide resolved
@iMicknl iMicknl marked this pull request as ready for review August 15, 2020 19:17
@iMicknl iMicknl requested a review from vlebourl as a code owner August 15, 2020 19:17
@iMicknl iMicknl force-pushed the enhancement/better_state_updates branch 2 times, most recently from fd04a93 to cf98cf7 Compare August 20, 2020 11:46
@iMicknl iMicknl requested a review from tetienne August 20, 2020 12:38
@iMicknl iMicknl requested a review from tetienne August 22, 2020 10:37
@iMicknl iMicknl requested a review from tetienne August 26, 2020 22:24
@iMicknl iMicknl force-pushed the enhancement/better_state_updates branch from 766b7f9 to 988a483 Compare August 27, 2020 13:18
@iMicknl iMicknl mentioned this pull request Aug 27, 2020
Closed
This was referenced Aug 27, 2020
Closed
Closed
@iMicknl iMicknl requested a review from tetienne August 30, 2020 09:20
@iMicknl iMicknl mentioned this pull request Aug 30, 2020
Closed
tetienne
tetienne requested changes Aug 30, 2020
View reviewed changes
custom_components/tahoma/__init__.py Outdated Show resolved Hide resolved
custom_components/tahoma/config_flow.py Show resolved Hide resolved
custom_components/tahoma/coordinator.py Outdated Show resolved Hide resolved
custom_components/tahoma/coordinator.py Outdated Show resolved Hide resolved
@tetienne tetienne force-pushed the enhancement/better_state_updates branch from 0d61cef to e6ff4e4 Compare August 30, 2020 19:21
@iMicknl iMicknl changed the title Improve entity update after command execution Improve entity update after command execution, add retry logic Aug 31, 2020
@iMicknl iMicknl requested a review from tetienne August 31, 2020 06:26
@iMicknl iMicknl merged commit aa92fdc into master Sep 1, 2020
@iMicknl iMicknl deleted the enhancement/better_state_updates branch September 1, 2020 10:22
iMicknl added a commit that referenced this pull request Sep 1, 2020
@iMicknl
Squashed commit of the following:
03110e4 
commit aa92fdc
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Tue Sep 1 12:22:14 2020 +0200

    Improve entity update after command execution, add retry logic (#227)

    Co-authored-by: Thibaut <thibaut@etienne.pw>

commit 6449730
Author: Vincent Le Bourlot <vlebourl@gmail.com>
Date:   Tue Sep 1 10:52:43 2020 +0200

    Moved climate devices files to their own directory. (#250)

    * Moved climate devices files to their own directory.

    * Renamed to snake_case

commit 3e78829
Author: Vincent Le Bourlot <vlebourl@gmail.com>
Date:   Mon Aug 31 08:54:35 2020 +0200

    Remove auto changelog as it looks messy and unreliable. (#243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlebourl vlebourl vlebourl approved these changes

@tetienne tetienne tetienne approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement is_closing and is_opening for covers
3 participants
@iMicknl @vlebourl @tetienne