Use deployment state for the horizontal #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it, @tetienne! Do you want to notify users already to validate this fix, or do you want to make some changes first? |
|
I tested it quickly this morning. It seems ok. We can indeed notify them. |
|
I keep this PR as draft. I think I can still clean the code. |
iMicknl
reviewed
Apr 19, 2021
This was referenced Apr 19, 2021
Closed
tetienne
commented
Apr 19, 2021
custom_components/tahoma/cover.py
Outdated
| @@ -218,6 +219,8 @@ def is_closed(self): | |||
| ) | |||
|
|
|||
| if state is not None: | |||
| if self.has_state(CORE_DEPLOYMENT_STATE): | |||
| return state == STATE_OPENED | |||
|
Wondering, if instead I can test this: |
tetienne
force-pushed
the
enhancement/horizontal-deployment
branch
from
90f0daa
to
004d668
Compare
|
@tetienne this one is still a draft, could it be merged? |
I have to double check the code is still OK with my awning. |
|
Works fine with my own device. |
|
Ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #352 #411 and #419