Add support for priority lock #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tetienne
commented
Aug 24, 2021
•
tetienne
commented
iMicknl
reviewed
Aug 24, 2021
iMicknl
reviewed
Aug 24, 2021
tetienne
commented
Aug 24, 2021
| OverkizSensorDescription( | ||
| key="io:PriorityLockOriginatorState", | ||
| name="Priority Lock Originator", | ||
| value=lambda value: str(value).capitalize(), |
There was a problem hiding this comment.
I hesitate with Unlocked as default value for this one, instead of Unknown.
iMicknl
approved these changes
Aug 24, 2021
iMicknl
reviewed
Aug 24, 2021
| @@ -128,19 +123,6 @@ def is_closed(self): | |||
|
|
|||
| return None | |||
|
|
|||
| @property | |||
| def icon(self): | |||
There was a problem hiding this comment.
Finally we got rid of this part <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.