Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stop button #712

Merged
merged 1 commit into from
Jan 15, 2022
Merged

Fix stop button #712

merged 1 commit into from
Jan 15, 2022

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Jan 15, 2022 •
edited by gitpod-io bot
Loading

Fixes #710

@github-actions github-actions bot added the bug Something isn't working label Jan 15, 2022
tetienne
tetienne approved these changes Jan 15, 2022
View reviewed changes
Copy link
Collaborator

@tetienne tetienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdness we never got an error

@iMicknl
Copy link
Owner Author

iMicknl commented Jan 15, 2022

Weirdness we never got an error

Not many users have a pergola and/or use the stop feature apparently...

@iMicknl iMicknl merged commit f879d6a into master Jan 15, 2022
@iMicknl iMicknl deleted the fix/cover_tilt_stop branch January 15, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetienne tetienne tetienne approved these changes

@vlebourl vlebourl Awaiting requested review from vlebourl vlebourl is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'OverkizExecutor' object has no attribute 'async_cancel_or_stop_cover'
2 participants
@iMicknl @tetienne