Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load integration if core integration is configured #734

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Jan 26, 2022

Screen Shot 2022-01-26 at 17 59 50

Not perfect since it will only check a boot / reload, however I think that would be good enough for now. Let's make sure that users don't configure both integrations.

@github-actions github-actions bot added the enhancement New feature or request label Jan 26, 2022
tetienne
tetienne previously approved these changes Jan 26, 2022
Copy link
Collaborator

@tetienne tetienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we will not backport this to the Core?

Co-authored-by: Thibaut <thibaut@etienne.pw>
@iMicknl
Copy link
Owner Author

iMicknl commented Jan 26, 2022

I guess we will not backport this to the Core?

Nope! We just need it here :)

@iMicknl iMicknl merged commit 364b62e into master Jan 26, 2022
@iMicknl iMicknl deleted the enhancement/block_if_core_is_used branch January 26, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants